From: Dan Carpenter Date: Fri, 4 Mar 2022 13:14:49 +0000 (+0300) Subject: ASoC: amd: acp: Fix signedness bug in renoir_audio_probe() X-Git-Tag: v6.6.17~6759^2~120^2~75 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=899a9a7f624b5a9d100c9ac6b3f0960981f0e4c5;p=platform%2Fkernel%2Flinux-rpi.git ASoC: amd: acp: Fix signedness bug in renoir_audio_probe() The "adata->i2s_irq" is unsigned so this error handling will not work. Fixes: 3304a242f45a ("ASoC: amd: Use platform_get_irq_byname() to get the interrupt") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/20220304131449.GC28739@kili Signed-off-by: Mark Brown --- diff --git a/sound/soc/amd/acp/acp-renoir.c b/sound/soc/amd/acp/acp-renoir.c index 738cf2e..75c9229 100644 --- a/sound/soc/amd/acp/acp-renoir.c +++ b/sound/soc/amd/acp/acp-renoir.c @@ -282,9 +282,10 @@ static int renoir_audio_probe(struct platform_device *pdev) if (!adata->acp_base) return -ENOMEM; - adata->i2s_irq = platform_get_irq_byname(pdev, "acp_dai_irq"); - if (adata->i2s_irq < 0) - return -ENODEV; + ret = platform_get_irq_byname(pdev, "acp_dai_irq"); + if (ret < 0) + return ret; + adata->i2s_irq = ret; adata->dev = dev; adata->dai_driver = acp_renoir_dai;