From: DJ Delorie <dj@redhat.com>
Date: Thu, 28 Jul 2005 20:08:15 +0000 (+0000)
Subject: * ldlang.c (lang_output_section_statement_lookup_1): Don't cast a
X-Git-Tag: gdb-csl-arm-20051020-branchpoint~593
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8980686623b0a9734f23edbf48b6dc7a803cec8b;p=platform%2Fupstream%2Fbinutils.git

* ldlang.c (lang_output_section_statement_lookup_1): Don't cast a
unary & address operator, as that breaks GCC's strict aliasing
rules.
---

diff --git a/ld/ChangeLog b/ld/ChangeLog
index 460fb39..d218b95 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,9 @@
+2005-07-28  DJ Delorie  <dj@redhat.com>
+
+	* ldlang.c (lang_output_section_statement_lookup_1): Don't cast a
+	unary & address operator, as that breaks GCC's strict aliasing
+	rules.
+
 2005-07-25  Jan Hubicka  <jh@suse.cz>
 	    H.J. Lu  <hongjiu.lu@intel.com>
 
diff --git a/ld/ldlang.c b/ld/ldlang.c
index dc8aa14..7cdb7c8 100644
--- a/ld/ldlang.c
+++ b/ld/ldlang.c
@@ -1010,6 +1010,7 @@ static lang_output_section_statement_type *
 lang_output_section_statement_lookup_1 (const char *const name, int constraint)
 {
   lang_output_section_statement_type *lookup;
+  lang_output_section_statement_type **nextp;
 
   lookup = lang_output_section_find_1 (name, constraint);
   if (lookup == NULL)
@@ -1038,9 +1039,13 @@ lang_output_section_statement_lookup_1 (const char *const name, int constraint)
       lookup->update_dot_tree = NULL;
       lookup->phdrs = NULL;
 
+      /* GCC's strict aliasing rules prevent us from just casting the
+	 address, so we store the pointer in a variable and cast that
+	 instead.  */
+      nextp = &lookup->next;
       lang_statement_append (&lang_output_section_statement,
 			     (lang_statement_union_type *) lookup,
-			     (lang_statement_union_type **) &lookup->next);
+			     (lang_statement_union_type **) nextp);
     }
   return lookup;
 }