From: Axel Lin <axel.lin@gmail.com>
Date: Mon, 31 Oct 2011 03:00:06 +0000 (+0800)
Subject: mfd: Set adp5520 bits if new value is different from the old one
X-Git-Tag: upstream/snapshot3+hdmi~8519^2~10
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=890c98e3746fa8705cc9c70979e64360cf2d8a31;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

mfd: Set adp5520 bits if new value is different from the old one

Current code checks if all the bit_mask bits are all zero is wrong.
We need to write new value if the bit mask fields of new value is
not equal to old value.

Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Michael Hennerich <michael.hennerich@analog.com>
Signed-off-by: Samuel Ortiz <sameo@linux.intel.com>
---

diff --git a/drivers/mfd/adp5520.c b/drivers/mfd/adp5520.c
index f1d8848..8d816cc 100644
--- a/drivers/mfd/adp5520.c
+++ b/drivers/mfd/adp5520.c
@@ -109,7 +109,7 @@ int adp5520_set_bits(struct device *dev, int reg, uint8_t bit_mask)
 
 	ret = __adp5520_read(chip->client, reg, &reg_val);
 
-	if (!ret && ((reg_val & bit_mask) == 0)) {
+	if (!ret && ((reg_val & bit_mask) != bit_mask)) {
 		reg_val |= bit_mask;
 		ret = __adp5520_write(chip->client, reg, reg_val);
 	}