From: roel kluin <roel.kluin@gmail.com>
Date: Wed, 30 Dec 2009 01:43:45 +0000 (+0000)
Subject: net: Test off by one in sh_eth_reset()
X-Git-Tag: upstream/snapshot3+hdmi~15639^2~140
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=890c8c18986eb975a76aa8359a712596bc70e61c;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

net: Test off by one in sh_eth_reset()

If no break occurred, cnt reaches 0 after the loop.

Signed-off-by: Roel Kluin <roel.kluin@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/sh_eth.c b/drivers/net/sh_eth.c
index ca62850..7402b85 100644
--- a/drivers/net/sh_eth.c
+++ b/drivers/net/sh_eth.c
@@ -110,7 +110,7 @@ static void sh_eth_reset(struct net_device *ndev)
 		mdelay(1);
 		cnt--;
 	}
-	if (cnt < 0)
+	if (cnt == 0)
 		printk(KERN_ERR "Device reset fail\n");
 
 	/* Table Init */