From: Srinivas Pandruvada Date: Mon, 16 Jun 2014 19:00:00 +0000 (+0100) Subject: iio: accel: kxcjk1013 Fix missing unlock errors X-Git-Tag: v4.14-rc1~7109^2~1305^2~9 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=88f6da779a37a3579e580296776ba86d6c6bd980;p=platform%2Fkernel%2Flinux-rpi.git iio: accel: kxcjk1013 Fix missing unlock errors Fix unlock at two places. One when i2c error occurs and other when trigger set state when raw read is in progress. kbuild test robot errors: >> >> drivers/iio/accel/kxcjk-1013.c:531:3-9: preceding lock on line 524 >> >> drivers/iio/accel/kxcjk-1013.c:376:4-10: preceding lock on line 368 Signed-off-by: Srinivas Pandruvada Reported-by: Fengguang Wu Signed-off-by: Jonathan Cameron --- diff --git a/drivers/iio/accel/kxcjk-1013.c b/drivers/iio/accel/kxcjk-1013.c index 2326e43..72a6dbb 100644 --- a/drivers/iio/accel/kxcjk-1013.c +++ b/drivers/iio/accel/kxcjk-1013.c @@ -372,8 +372,10 @@ static int kxcjk1013_read_raw(struct iio_dev *indio_dev, int sleep_val; ret = kxcjk1013_set_mode(data, OPERATION); - if (ret < 0) + if (ret < 0) { + mutex_unlock(&data->mutex); return ret; + } ++data->power_state; sleep_val = kxcjk1013_get_startup_times(data); if (sleep_val < 20000) @@ -527,8 +529,10 @@ static int kxcjk1013_data_rdy_trigger_set_state(struct iio_trigger *trig, kxcjk1013_set_mode(data, OPERATION); ++data->power_state; } else { - if (--data->power_state) + if (--data->power_state) { + mutex_unlock(&data->mutex); return 0; + } kxcjk1013_chip_setup_interrupt(data, false); kxcjk1013_set_mode(data, STANDBY); }