From: Dan Carpenter Date: Mon, 1 Aug 2022 10:19:27 +0000 (+0300) Subject: cxl/region: uninitialized variable in alloc_hpa() X-Git-Tag: v6.6.17~6817^2~19 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=88ab1dde792aa6a3902e2a30929e00acc99d351a;p=platform%2Fkernel%2Flinux-rpi.git cxl/region: uninitialized variable in alloc_hpa() This should check "p->res" instead of "res" (which is uninitialized). Fixes: 23a22cd1c98b ("cxl/region: Allocate HPA capacity to regions") Signed-off-by: Dan Carpenter Link: https://lore.kernel.org/r/Yueor88I/DkVSOtL@kili Signed-off-by: Dan Williams --- diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c index dc71ec4..c80932b 100644 --- a/drivers/cxl/core/region.c +++ b/drivers/cxl/core/region.c @@ -454,7 +454,7 @@ static int alloc_hpa(struct cxl_region *cxlr, resource_size_t size) lockdep_assert_held_write(&cxl_region_rwsem); /* Nothing to do... */ - if (p->res && resource_size(res) == size) + if (p->res && resource_size(p->res) == size) return 0; /* To change size the old size must be freed first */