From: Dan Carpenter Date: Wed, 25 Oct 2023 11:57:23 +0000 (+0300) Subject: PCI: endpoint: Fix double free in __pci_epc_create() X-Git-Tag: v6.6.17~3247 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=88aa0b599b9c89e056502b5aeae9040e35a3239a;p=platform%2Fkernel%2Flinux-rpi.git PCI: endpoint: Fix double free in __pci_epc_create() [ Upstream commit c9501d268944d6c0475ecb3e740a084a7da9cbfe ] The pci_epc_release() function frees "epc" so the kfree() on the next line is a double free. Drop the redundant free. Fixes: 7711cbb4862a ("PCI: endpoint: Fix WARN() when an endpoint driver is removed") Link: https://lore.kernel.org/r/2ce68694-87a7-4c06-b8a4-9870c891b580@moroto.mountain Signed-off-by: Dan Carpenter Signed-off-by: Bjorn Helgaas Reviewed-by: Manivannan Sadhasivam Signed-off-by: Sasha Levin --- diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c index 5a4a8b0..a7d3a92 100644 --- a/drivers/pci/endpoint/pci-epc-core.c +++ b/drivers/pci/endpoint/pci-epc-core.c @@ -869,7 +869,6 @@ __pci_epc_create(struct device *dev, const struct pci_epc_ops *ops, put_dev: put_device(&epc->dev); - kfree(epc); err_ret: return ERR_PTR(ret);