From: 박종현/On-Device Lab(SR)/Staff Engineer/삼성전자 <jh1302.park@samsung.com>
Date: Fri, 1 Feb 2019 01:43:21 +0000 (+0900)
Subject: [coco.core] Explicitly specify link visibility (#2978)
X-Git-Tag: nncc_backup~889
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8883d20d688dc7ff8bb58afbb6e6babd00acf5bb;p=platform%2Fcore%2Fml%2Fnnfw.git

[coco.core] Explicitly specify link visibility (#2978)

This commit specifies link visibility over dependent libraries.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
---

diff --git a/contrib/coco/core/CMakeLists.txt b/contrib/coco/core/CMakeLists.txt
index ddbdaa2..0eafe44 100644
--- a/contrib/coco/core/CMakeLists.txt
+++ b/contrib/coco/core/CMakeLists.txt
@@ -4,9 +4,9 @@ list(REMOVE_ITEM SOURCES ${TESTS})
 
 add_library(coco_core SHARED ${SOURCES})
 target_include_directories(coco_core PUBLIC include)
-target_link_libraries(coco_core nncc_core)
-# TODO Set this as PRIVATE dependency
-target_link_libraries(coco_core stdex)
+# NOTE Some coco_core PUBLIC headers include nncc_core headers
+target_link_libraries(coco_core PUBLIC nncc_core)
+target_link_libraries(coco_core PRIVATE stdex)
 
 nncc_find_package(GTest QUIET)
 
@@ -18,3 +18,4 @@ nncc_include(OptionalTargetTools)
 
 coco_add_test(coco_core_test ${TESTS})
 optional_target_link_libraries(coco_core_test coco_core)
+optional_target_link_libraries(coco_core_test stdex)