From: Peter Korsgaard Date: Mon, 11 Oct 2010 13:02:06 +0000 (+0200) Subject: mxc/gpio: make _set_value work with values != 0/1 X-Git-Tag: v3.0~2928^2^2~3^2~38 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=886ab3dae2ba26bde5bab096c931365db9f49830;p=platform%2Fkernel%2Flinux-amlogic.git mxc/gpio: make _set_value work with values != 0/1 Documentation/gpio.txt specifies that the value argument to gpio_set_value() should be handled as a boolean (E.G. != 0 is high), so use the same logic as in _set_direction(). Signed-off-by: Peter Korsgaard Signed-off-by: Sascha Hauer --- diff --git a/arch/arm/plat-mxc/gpio.c b/arch/arm/plat-mxc/gpio.c index 57ec4a8..9d38da0 100644 --- a/arch/arm/plat-mxc/gpio.c +++ b/arch/arm/plat-mxc/gpio.c @@ -235,7 +235,7 @@ static void mxc_gpio_set(struct gpio_chip *chip, unsigned offset, int value) unsigned long flags; spin_lock_irqsave(&port->lock, flags); - l = (__raw_readl(reg) & (~(1 << offset))) | (value << offset); + l = (__raw_readl(reg) & (~(1 << offset))) | (!!value << offset); __raw_writel(l, reg); spin_unlock_irqrestore(&port->lock, flags); }