From: Yang Yingliang <yangyingliang@huawei.com>
Date: Fri, 18 Jun 2021 04:38:35 +0000 (+0800)
Subject: usb: gadget: hid: fix error return code in hid_bind()
X-Git-Tag: v5.15~788^2~11
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=88693f770bb09c196b1eb5f06a484a254ecb9924;p=platform%2Fkernel%2Flinux-starfive.git

usb: gadget: hid: fix error return code in hid_bind()

Fix to return a negative error code from the error handling
case instead of 0.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20210618043835.2641360-1-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/gadget/legacy/hid.c b/drivers/usb/gadget/legacy/hid.c
index c4eda7f..5b27d28 100644
--- a/drivers/usb/gadget/legacy/hid.c
+++ b/drivers/usb/gadget/legacy/hid.c
@@ -171,8 +171,10 @@ static int hid_bind(struct usb_composite_dev *cdev)
 		struct usb_descriptor_header *usb_desc;
 
 		usb_desc = usb_otg_descriptor_alloc(gadget);
-		if (!usb_desc)
+		if (!usb_desc) {
+			status = -ENOMEM;
 			goto put;
+		}
 		usb_otg_descriptor_init(gadget, usb_desc);
 		otg_desc[0] = usb_desc;
 		otg_desc[1] = NULL;