From: 박종현/동작제어Lab(SR)/Staff Engineer/삼성전자 <jh1302.park@samsung.com>
Date: Fri, 14 Sep 2018 09:24:26 +0000 (+0900)
Subject: [coco] Remove unnecessary methods for bag link update (#1497)
X-Git-Tag: nncc_backup~1815
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=88645a637321e9d73d0d107ec6b0c3ae01a105dc;p=platform%2Fcore%2Fml%2Fnnfw.git

[coco] Remove unnecessary methods for bag link update (#1497)

This commit removes all of unnecessary methods introduced to deliver bag
link to each Dep.

Signed-off-by: Jonghyun Park <jh1302.park@samsung.com>
---

diff --git a/contrib/coco/core/include/coco/IR/Dep.h b/contrib/coco/core/include/coco/IR/Dep.h
index d5a26b7..240d37b 100644
--- a/contrib/coco/core/include/coco/IR/Dep.h
+++ b/contrib/coco/core/include/coco/IR/Dep.h
@@ -36,10 +36,6 @@ public:
   Object *object(void) const { return _object; }
   void object(Object *object) { _object = object; }
 
-public:
-  // WARN This method is deprecated
-  void link(const PtrLink<Bag, BagInfo> *link) { return; }
-
 private:
   Bag *_bag = nullptr;
   Object *_object = nullptr;
diff --git a/contrib/coco/core/include/coco/IR/Object.h b/contrib/coco/core/include/coco/IR/Object.h
index 33e9899..a57fdf3 100644
--- a/contrib/coco/core/include/coco/IR/Object.h
+++ b/contrib/coco/core/include/coco/IR/Object.h
@@ -41,7 +41,6 @@ public:
 
 protected:
   virtual void get(ObjectInfo **) const = 0;
-  void setBagLink(const PtrLink<Bag, BagInfo> *);
 
 public:
   coco::Bag *bag(void) const { return _dep.bag(); }
diff --git a/contrib/coco/core/src/IR/Dep.test.cpp b/contrib/coco/core/src/IR/Dep.test.cpp
index 87c93eb..ce9097f 100644
--- a/contrib/coco/core/src/IR/Dep.test.cpp
+++ b/contrib/coco/core/src/IR/Dep.test.cpp
@@ -51,7 +51,6 @@ TEST_F(DepTest, bag_update_with_link_and_object)
 
   coco::Dep dep;
 
-  dep.link(&bag_link);
   dep.object(obj);
 
   dep.bag(bag);
diff --git a/contrib/coco/core/src/IR/FeatureObject.cpp b/contrib/coco/core/src/IR/FeatureObject.cpp
index 41aba73..f097858 100644
--- a/contrib/coco/core/src/IR/FeatureObject.cpp
+++ b/contrib/coco/core/src/IR/FeatureObject.cpp
@@ -17,7 +17,6 @@ FeatureObject::FeatureObject(std::unique_ptr<FeatureObjectInfo> &&info,
                              const PtrLink<Bag, BagInfo> *link)
     : _info(std::move(info))
 {
-  setBagLink(link);
   _map.resize(nncc::core::ADT::feature::num_elements(shape()));
 }
 
diff --git a/contrib/coco/core/src/IR/KernelObject.cpp b/contrib/coco/core/src/IR/KernelObject.cpp
index d05c9a9..f2d656b 100644
--- a/contrib/coco/core/src/IR/KernelObject.cpp
+++ b/contrib/coco/core/src/IR/KernelObject.cpp
@@ -17,7 +17,6 @@ KernelObject::KernelObject(std::unique_ptr<KernelObjectInfo> &&info,
                            const PtrLink<Bag, BagInfo> *link)
     : _info{std::move(info)}
 {
-  setBagLink(link);
   _map.resize(nncc::core::ADT::kernel::num_elements(shape()));
 }
 
diff --git a/contrib/coco/core/src/IR/Object.cpp b/contrib/coco/core/src/IR/Object.cpp
index ba3deee..ff5a262 100644
--- a/contrib/coco/core/src/IR/Object.cpp
+++ b/contrib/coco/core/src/IR/Object.cpp
@@ -15,8 +15,6 @@ Object::Object()
   _dep.object(this);
 }
 
-void Object::setBagLink(const PtrLink<Bag, BagInfo> *bag_link) { _dep.link(bag_link); }
-
 ObjectInfo *Object::info(void) const
 {
   ObjectInfo *res = nullptr;
diff --git a/contrib/coco/core/src/IR/Object.test.cpp b/contrib/coco/core/src/IR/Object.test.cpp
index dad3828..c1a042e 100644
--- a/contrib/coco/core/src/IR/Object.test.cpp
+++ b/contrib/coco/core/src/IR/Object.test.cpp
@@ -35,9 +35,6 @@ public:
 public:
   std::unique_ptr<coco::ObjectInfo> info;
 
-public:
-  void link(const coco::PtrLink<coco::Bag, coco::BagInfo> *link) { setBagLink(link); }
-
 private:
   void get(coco::ObjectInfo **out) const override { *out = info.get(); }
 };
@@ -67,7 +64,6 @@ TEST_F(ObjectTest, bag_update)
   ::mock::Object obj;
 
   obj.info = make_unique<coco::ObjectInfo>();
-  obj.link(&link);
 
   obj.bag(bag);
 
@@ -101,7 +97,6 @@ TEST_F(ObjectTest, destructor)
     ::mock::Object obj;
 
     obj.info = make_unique<coco::ObjectInfo>();
-    obj.link(&link);
 
     obj.bag(bag);
   }