From: Azeem Shaikh Date: Wed, 10 May 2023 21:11:46 +0000 (+0000) Subject: vboxsf: Replace all non-returning strlcpy with strscpy X-Git-Tag: v6.6.7~2390^2~44 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=883f8fe87686d1deef2614b1d3a23ca7e5193dff;p=platform%2Fkernel%2Flinux-starfive.git vboxsf: Replace all non-returning strlcpy with strscpy strlcpy() reads the entire source buffer first. This read may exceed the destination size limit. This is both inefficient and can lead to linear read overflows if a source string is not NUL-terminated [1]. In an effort to remove strlcpy() completely [2], replace strlcpy() here with strscpy(). No return values were used, so direct replacement is safe. [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#strlcpy [2] https://github.com/KSPP/linux/issues/89 Signed-off-by: Azeem Shaikh Reviewed-by: Hans de Goede Reviewed-by: Kees Cook Signed-off-by: Kees Cook Link: https://lore.kernel.org/r/20230510211146.3486600-1-azeemshaikh38@gmail.com --- diff --git a/fs/vboxsf/super.c b/fs/vboxsf/super.c index d2f6df6..1fb8f4d 100644 --- a/fs/vboxsf/super.c +++ b/fs/vboxsf/super.c @@ -176,7 +176,7 @@ static int vboxsf_fill_super(struct super_block *sb, struct fs_context *fc) } folder_name->size = size; folder_name->length = size - 1; - strlcpy(folder_name->string.utf8, fc->source, size); + strscpy(folder_name->string.utf8, fc->source, size); err = vboxsf_map_folder(folder_name, &sbi->root); kfree(folder_name); if (err) {