From: Neal Cardwell Date: Thu, 7 Dec 2017 17:43:32 +0000 (-0500) Subject: tcp_bbr: reset long-term bandwidth sampling on loss recovery undo X-Git-Tag: v4.9.75~39 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8824b2d7abfb113e33eae268ea22b11eb15b30b4;p=platform%2Fkernel%2Flinux-amlogic.git tcp_bbr: reset long-term bandwidth sampling on loss recovery undo commit 600647d467c6d04b3954b41a6ee1795b5ae00550 upstream. Fix BBR so that upon notification of a loss recovery undo BBR resets long-term bandwidth sampling. Under high reordering, reordering events can be interpreted as loss. If the reordering and spurious loss estimates are high enough, this can cause BBR to spuriously estimate that we are seeing loss rates high enough to trigger long-term bandwidth estimation. To avoid that problem, this commit resets long-term bandwidth sampling on loss recovery undo events. Signed-off-by: Neal Cardwell Reviewed-by: Yuchung Cheng Acked-by: Soheil Hassas Yeganeh Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- diff --git a/net/ipv4/tcp_bbr.c b/net/ipv4/tcp_bbr.c index 64ff496..e86a34f 100644 --- a/net/ipv4/tcp_bbr.c +++ b/net/ipv4/tcp_bbr.c @@ -847,6 +847,7 @@ static u32 bbr_undo_cwnd(struct sock *sk) bbr->full_bw = 0; /* spurious slow-down; reset full pipe detection */ bbr->full_bw_cnt = 0; + bbr_reset_lt_bw_sampling(sk); return tcp_sk(sk)->snd_cwnd; }