From: Johannes Berg Date: Wed, 1 Mar 2023 10:09:29 +0000 (+0200) Subject: wifi: nl80211: fix NULL-ptr deref in offchan check X-Git-Tag: v6.1.21~166 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=87e80ea4fbc9ce2f2005905fdbcd38baaa47463a;p=platform%2Fkernel%2Flinux-starfive.git wifi: nl80211: fix NULL-ptr deref in offchan check [ Upstream commit f624bb6fad23df3270580b4fcef415c6e7bf7705 ] If, e.g. in AP mode, the link was already created by userspace but not activated yet, it has a chandef but the chandef isn't valid and has no channel. Check for this and ignore this link. Fixes: 7b0a0e3c3a88 ("wifi: cfg80211: do some rework towards MLO link APIs") Signed-off-by: Johannes Berg Signed-off-by: Gregory Greenman Link: https://lore.kernel.org/r/20230301115906.71bd4803fbb9.Iee39c0f6c2d3a59a8227674dc55d52e38b1090cf@changeid Signed-off-by: Johannes Berg Signed-off-by: Sasha Levin --- diff --git a/net/wireless/nl80211.c b/net/wireless/nl80211.c index 4d4de49..4c6748a 100644 --- a/net/wireless/nl80211.c +++ b/net/wireless/nl80211.c @@ -8815,7 +8815,7 @@ static bool cfg80211_off_channel_oper_allowed(struct wireless_dev *wdev, struct cfg80211_chan_def *chandef; chandef = wdev_chandef(wdev, link_id); - if (!chandef) + if (!chandef || !chandef->chan) continue; /*