From: Dan Carpenter Date: Wed, 1 Feb 2012 07:46:20 +0000 (+0300) Subject: SUNRPC: remove an unneeded NULL check in xprt_connect() X-Git-Tag: upstream/snapshot3+hdmi~7900^2~134 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=87e3c0553fcbea79bf9f17fc5694484ecf3ae5e8;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git SUNRPC: remove an unneeded NULL check in xprt_connect() We check "task->tk_rqstp" and then we dereference it without checking on the next line. The only caller is call_connect() and that has a check which prevents it from calling xprt_connect() with a NULL. if (task->tk_status < 0) return; If "task->tk_rqstp" were NULL then "tk_status" would be -EAGAIN. Signed-off-by: Dan Carpenter Signed-off-by: Trond Myklebust --- diff --git a/net/sunrpc/xprt.c b/net/sunrpc/xprt.c index 839f6ef..efe5495 100644 --- a/net/sunrpc/xprt.c +++ b/net/sunrpc/xprt.c @@ -715,9 +715,7 @@ void xprt_connect(struct rpc_task *task) if (xprt_connected(xprt)) xprt_release_write(xprt, task); else { - if (task->tk_rqstp) - task->tk_rqstp->rq_bytes_sent = 0; - + task->tk_rqstp->rq_bytes_sent = 0; task->tk_timeout = task->tk_rqstp->rq_timeout; rpc_sleep_on(&xprt->pending, task, xprt_connect_status);