From: Johan Hovold Date: Thu, 21 Mar 2013 11:37:37 +0000 (+0100) Subject: USB: cypress_m8: remove bogus disconnect test from close X-Git-Tag: v3.10-rc1~190^2~129 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=87ddf4dc16d93db92431d57c4b2fcd640f428228;p=platform%2Fkernel%2Flinux-3.10.git USB: cypress_m8: remove bogus disconnect test from close Remove disconnected test from close which did not protect any device IO at all. Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/usb/serial/cypress_m8.c b/drivers/usb/serial/cypress_m8.c index e4a62cf..d341555 100644 --- a/drivers/usb/serial/cypress_m8.c +++ b/drivers/usb/serial/cypress_m8.c @@ -632,12 +632,6 @@ static void cypress_close(struct usb_serial_port *port) struct cypress_private *priv = usb_get_serial_port_data(port); unsigned long flags; - /* writing is potentially harmful, lock must be taken */ - mutex_lock(&port->serial->disc_mutex); - if (port->serial->disconnected) { - mutex_unlock(&port->serial->disc_mutex); - return; - } spin_lock_irqsave(&priv->lock, flags); kfifo_reset_out(&priv->write_fifo); spin_unlock_irqrestore(&priv->lock, flags); @@ -649,7 +643,6 @@ static void cypress_close(struct usb_serial_port *port) if (stats) dev_info(&port->dev, "Statistics: %d Bytes In | %d Bytes Out | %d Commands Issued\n", priv->bytes_in, priv->bytes_out, priv->cmd_count); - mutex_unlock(&port->serial->disc_mutex); } /* cypress_close */