From: Jakob Sinclair Date: Wed, 18 May 2016 17:48:29 +0000 (+0200) Subject: gallium/radeon: fixed division by zero X-Git-Tag: upstream/17.1.0~9128 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=877c00c653ac782f8867a3fee24f16707b1d568c;p=platform%2Fupstream%2Fmesa.git gallium/radeon: fixed division by zero Coverity is getting a false positive that a division by zero can occur here. This change will silence the Coverity warnings as a division by zero cannot occur in this case. Signed-off-by: Jakob Sinclair Reviewed-by: Nicolai Hähnle Signed-off-by: Marek Olšák --- diff --git a/src/gallium/drivers/radeon/r600_test_dma.c b/src/gallium/drivers/radeon/r600_test_dma.c index c203b4d..1e60f6a 100644 --- a/src/gallium/drivers/radeon/r600_test_dma.c +++ b/src/gallium/drivers/radeon/r600_test_dma.c @@ -345,6 +345,9 @@ void r600_test_dma(struct r600_common_screen *rscreen) dstx = rand() % (tdst.width0 - width + 1) & ~0x7; dsty = rand() % (tdst.height0 - height + 1) & ~0x7; } else { + /* just make sure that it doesn't divide by zero */ + assert(max_width > 0 && max_height > 0); + width = (rand() % max_width) + 1; height = (rand() % max_height) + 1;