From: SangYoun Kwak <sy.kwak@samsung.com>
Date: Thu, 20 Jun 2024 06:39:05 +0000 (+0900)
Subject: osu: Fix to return non-zero if upgrade is failed
X-Git-Tag: accepted/tizen/8.0/unified/20240626.155902~1
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8739d9f992e96fcb0e944b870fd915d378cf7f98;p=platform%2Fcore%2Fsystem%2Fupdate-control.git

osu: Fix to return non-zero if upgrade is failed

In the previous code, osu returned 0 even if upgrade is failed, due to
the deinitialization code. Previously, if error occured during the
upgrade, aborted the rest works and called the deinitialization function
'update_control_deinitialize' and returned its return value.
This caused osu to return 0 even an error is occured, which is invalid
behavior.
To fix this issue, the return value of deinitialization function is
treated as a different variable.

Change-Id: Ie536bafc5bb4e31f461cf1df98db496d77a24664
Signed-off-by: SangYoun Kwak <sy.kwak@samsung.com>
---

diff --git a/tools/osu/update.c b/tools/osu/update.c
index 458bb90..3df4c15 100644
--- a/tools/osu/update.c
+++ b/tools/osu/update.c
@@ -6,6 +6,8 @@
 int do_update(void)
 {
 	int ret = 0;
+	int ret_deinit = 0;
+
 	ret = update_control_initialize();
 	if (ret != UPDATE_CONTROL_ERROR_NONE) {
 		printf("Failed to initialize: %d\n", ret);
@@ -35,9 +37,11 @@ int do_update(void)
 	printf("Succeed to trigger update: %d\n", ret);
 
 cleanup:
-	ret = update_control_deinitialize();
-	if (ret != UPDATE_CONTROL_ERROR_NONE)
-		printf("Failed to deinitialize: %d\n", ret);
+	ret_deinit = update_control_deinitialize();
+	if (ret_deinit != UPDATE_CONTROL_ERROR_NONE) {
+		printf("Failed to deinitialize: %d\n", ret_deinit);
+		return ret_deinit;
+	}
 
 	return ret;
 }