From: Douglas Anderson Date: Fri, 20 Oct 2023 21:06:53 +0000 (-0700) Subject: r8152: Run the unload routine if we have errors during probe X-Git-Tag: v6.1.63~490 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=87376143df3f8d92beab7dcc2a0275984ec37a3d;p=sdk%2Femulator%2Femulator-kernel.git r8152: Run the unload routine if we have errors during probe [ Upstream commit 5dd17689526971c5ae12bc8398f34bd68cd0499e ] The rtl8152_probe() function lacks a call to the chip-specific unload() routine when it sees an error in probe. Add it in to match the cleanup code in rtl8152_disconnect(). Fixes: ac718b69301c ("net/usb: new driver for RTL8152") Signed-off-by: Douglas Anderson Reviewed-by: Grant Grundler Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c index 4c90f7053171..3cc8e324c5c6 100644 --- a/drivers/net/usb/r8152.c +++ b/drivers/net/usb/r8152.c @@ -9826,6 +9826,8 @@ static int rtl8152_probe(struct usb_interface *intf, out1: tasklet_kill(&tp->tx_tl); + if (tp->rtl_ops.unload) + tp->rtl_ops.unload(tp); usb_set_intfdata(intf, NULL); out: free_netdev(netdev);