From: Brian Norris Date: Mon, 18 Dec 2017 23:30:48 +0000 (-0800) Subject: PM / wakeup: only recommend "call"ing device_init_wakeup() once X-Git-Tag: v4.19~1775^2~2^2~20 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=86ddd2db1f75a30f21a4c4de7a29249ee8c37ed8;p=platform%2Fkernel%2Flinux-rpi.git PM / wakeup: only recommend "call"ing device_init_wakeup() once I'll admit admit it: I've written bad driver code that tries to configure a device's wake IRQ without having called device_init_wakeup() first. But do you really have to ask ask me twice? Signed-off-by: Brian Norris Signed-off-by: Rafael J. Wysocki --- diff --git a/drivers/base/power/wakeup.c b/drivers/base/power/wakeup.c index 38559f0..cb72965 100644 --- a/drivers/base/power/wakeup.c +++ b/drivers/base/power/wakeup.c @@ -298,7 +298,7 @@ int device_wakeup_attach_irq(struct device *dev, ws = dev->power.wakeup; if (!ws) { - dev_err(dev, "forgot to call call device_init_wakeup?\n"); + dev_err(dev, "forgot to call device_init_wakeup?\n"); return -EINVAL; }