From: Francisco Jerez Date: Thu, 16 Jul 2015 12:58:56 +0000 (+0300) Subject: i965/fs: Fix return value of fs_inst::regs_read() for BAD_FILE. X-Git-Tag: upstream/17.1.0~17350 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=86ae788baefefdb2fa77fe3c242ad2d81c8e834e;p=platform%2Fupstream%2Fmesa.git i965/fs: Fix return value of fs_inst::regs_read() for BAD_FILE. Typically BAD_FILE sources are used to mark a source as not present what implies that no registers are read. This will become much more frequent with logical send opcodes which have a large number of sources, many of them optionally used and marked as BAD_FILE when they aren't applicable. It will prove to be useful to be able to rely on the value of regs_read() regardless of whether a source is present or not. Reviewed-by: Jason Ekstrand --- diff --git a/src/mesa/drivers/dri/i965/brw_fs.cpp b/src/mesa/drivers/dri/i965/brw_fs.cpp index 9d702a6..57e4290 100644 --- a/src/mesa/drivers/dri/i965/brw_fs.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs.cpp @@ -727,6 +727,7 @@ fs_inst::regs_read(int arg) const switch (src[arg].file) { case BAD_FILE: + return 0; case UNIFORM: case IMM: return 1;