From: Dinghao Liu <dinghao.liu@zju.edu.cn>
Date: Sat, 9 Jan 2021 12:01:21 +0000 (+0800)
Subject: netfilter: nf_nat: Fix memleak in nf_nat_init
X-Git-Tag: accepted/tizen/unified/20230118.172025~8087^2~16^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=869f4fdaf4ca7bb6e0d05caf6fa1108dddc346a7;p=platform%2Fkernel%2Flinux-rpi.git

netfilter: nf_nat: Fix memleak in nf_nat_init

When register_pernet_subsys() fails, nf_nat_bysource
should be freed just like when nf_ct_extend_register()
fails.

Fixes: 1cd472bf036ca ("netfilter: nf_nat: add nat hook register functions to nf_nat")
Signed-off-by: Dinghao Liu <dinghao.liu@zju.edu.cn>
Acked-by: Florian Westphal <fw@strlen.de>
Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
---

diff --git a/net/netfilter/nf_nat_core.c b/net/netfilter/nf_nat_core.c
index ea923f8c..b7c3c90 100644
--- a/net/netfilter/nf_nat_core.c
+++ b/net/netfilter/nf_nat_core.c
@@ -1174,6 +1174,7 @@ static int __init nf_nat_init(void)
 	ret = register_pernet_subsys(&nat_net_ops);
 	if (ret < 0) {
 		nf_ct_extend_unregister(&nat_extend);
+		kvfree(nf_nat_bysource);
 		return ret;
 	}