From: Vineeth TM <vineeth.tm@samsung.com>
Date: Tue, 21 Jul 2015 03:44:55 +0000 (+0900)
Subject: rmdemux: fix wrong unref when there are no tags
X-Git-Tag: 1.19.3~505^2~397
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=868a885040f10f10782860031b7798d6f255a8b1;p=platform%2Fupstream%2Fgstreamer.git

rmdemux: fix wrong unref when there are no tags

Tags should be appended to pending tags and unref'ed only if tags
are present. Else there is no need to append.

https://bugzilla.gnome.org/show_bug.cgi?id=752404
---

diff --git a/gst/realmedia/rmdemux.c b/gst/realmedia/rmdemux.c
index 08b798b..f170b21 100644
--- a/gst/realmedia/rmdemux.c
+++ b/gst/realmedia/rmdemux.c
@@ -1929,11 +1929,13 @@ gst_rmdemux_parse_cont (GstRMDemux * rmdemux, const guint8 * data, int length)
 
   tags = gst_rm_utils_read_tags (data, length, gst_rm_utils_read_string16);
 
-  GST_LOG_OBJECT (rmdemux, "tags: %" GST_PTR_FORMAT, tags);
+  if (tags) {
+    GST_LOG_OBJECT (rmdemux, "tags: %" GST_PTR_FORMAT, tags);
 
-  rmdemux->pending_tags =
-      gst_tag_list_merge (rmdemux->pending_tags, tags, GST_TAG_MERGE_APPEND);
-  gst_tag_list_unref (tags);
+    rmdemux->pending_tags =
+        gst_tag_list_merge (rmdemux->pending_tags, tags, GST_TAG_MERGE_APPEND);
+    gst_tag_list_unref (tags);
+  }
 }
 
 static void