From: Nico Weber Date: Mon, 2 Apr 2018 17:32:48 +0000 (+0000) Subject: Remove HAVE_LIBPSAPI, HAVE_SHELL32. X-Git-Tag: llvmorg-7.0.0-rc1~9198 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=868112181b596ec4f310dc4442e93379d0217bdd;p=platform%2Fupstream%2Fllvm.git Remove HAVE_LIBPSAPI, HAVE_SHELL32. These used to be set in the old autoconf build, but the cmake build has had a "TODO: actually check for these" comment since it was checked in, and they were set to 1 on mingw unconditionally. It seems safe to say that they always exist under mingw, so just remove them and assume they're set exactly when on mingw (with msvc, we use `pragma comment` instead of linking these via flags). llvm-svn: 328992 --- diff --git a/llvm/cmake/config-ix.cmake b/llvm/cmake/config-ix.cmake index a7dc805..ad9d917 100644 --- a/llvm/cmake/config-ix.cmake +++ b/llvm/cmake/config-ix.cmake @@ -434,13 +434,6 @@ else () endif () endif () -if( MINGW ) - set(HAVE_LIBPSAPI 1) - set(HAVE_LIBSHELL32 1) - # TODO: Check existence of libraries. - # include(CheckLibraryExists) -endif( MINGW ) - if( MSVC ) set(SHLIBEXT ".lib") set(stricmp "_stricmp") diff --git a/llvm/include/llvm/Config/config.h.cmake b/llvm/include/llvm/Config/config.h.cmake index bb378fc8..c8cfb7b 100644 --- a/llvm/include/llvm/Config/config.h.cmake +++ b/llvm/include/llvm/Config/config.h.cmake @@ -91,9 +91,6 @@ /* Define to 1 if you have the `edit' library (-ledit). */ #cmakedefine HAVE_LIBEDIT ${HAVE_LIBEDIT} -/* Define to 1 if you have the `psapi' library (-lpsapi). */ -#cmakedefine HAVE_LIBPSAPI ${HAVE_LIBPSAPI} - /* Define to 1 if you have the `pthread' library (-lpthread). */ #cmakedefine HAVE_LIBPTHREAD ${HAVE_LIBPTHREAD} @@ -103,9 +100,6 @@ /* Define to 1 if you have the `pthread_setname_np' function. */ #cmakedefine HAVE_PTHREAD_SETNAME_NP ${HAVE_PTHREAD_SETNAME_NP} -/* Define to 1 if you have the `shell32' library (-lshell32). */ -#cmakedefine HAVE_LIBSHELL32 ${HAVE_LIBSHELL32} - /* Define to 1 if you have the `z' library (-lz). */ #cmakedefine HAVE_LIBZ ${HAVE_LIBZ} diff --git a/llvm/lib/Support/Windows/Process.inc b/llvm/lib/Support/Windows/Process.inc index 3fe9f89..06b32ea 100644 --- a/llvm/lib/Support/Windows/Process.inc +++ b/llvm/lib/Support/Windows/Process.inc @@ -24,14 +24,7 @@ #include #include -#ifdef __MINGW32__ - #if (HAVE_LIBPSAPI != 1) - #error "libpsapi.a should be present" - #endif - #if (HAVE_LIBSHELL32 != 1) - #error "libshell32.a should be present" - #endif -#else +#if !defined(__MINGW32__) #pragma comment(lib, "psapi.lib") #pragma comment(lib, "shell32.lib") #endif diff --git a/llvm/lib/Support/Windows/Signals.inc b/llvm/lib/Support/Windows/Signals.inc index 23fc72e..893d18a 100644 --- a/llvm/lib/Support/Windows/Signals.inc +++ b/llvm/lib/Support/Windows/Signals.inc @@ -36,9 +36,6 @@ #ifdef _MSC_VER #pragma comment(lib, "psapi.lib") #elif __MINGW32__ - #if (HAVE_LIBPSAPI != 1) - #error "libpsapi.a should be present" - #endif // The version of g++ that comes with MinGW does *not* properly understand // the ll format specifier for printf. However, MinGW passes the format // specifiers on to the MSVCRT entirely, and the CRT understands the ll