From: Andy Shevchenko Date: Mon, 25 Oct 2021 13:51:46 +0000 (+0300) Subject: tty: rpmsg: Use dev_err_probe() in ->probe() X-Git-Tag: v6.1-rc5~2726^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8673ef7bd96dd75ed308cb71d48a292eaa1b72fa;p=platform%2Fkernel%2Flinux-starfive.git tty: rpmsg: Use dev_err_probe() in ->probe() It's fine to use dev_err_probe() in ->probe() even if we know it won't be deferred. Signed-off-by: Andy Shevchenko Link: https://lore.kernel.org/r/20211025135148.53944-3-andriy.shevchenko@linux.intel.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/rpmsg_tty.c b/drivers/tty/rpmsg_tty.c index fc5d33d..d172dd3 100644 --- a/drivers/tty/rpmsg_tty.c +++ b/drivers/tty/rpmsg_tty.c @@ -153,10 +153,8 @@ static int rpmsg_tty_probe(struct rpmsg_device *rpdev) int ret; cport = rpmsg_tty_alloc_cport(); - if (IS_ERR(cport)) { - dev_err(dev, "Failed to alloc tty port\n"); - return PTR_ERR(cport); - } + if (IS_ERR(cport)) + return dev_err_probe(dev, PTR_ERR(cport), "Failed to alloc tty port\n"); tty_port_init(&cport->port); cport->port.ops = &rpmsg_tty_port_ops; @@ -164,9 +162,8 @@ static int rpmsg_tty_probe(struct rpmsg_device *rpdev) tty_dev = tty_port_register_device(&cport->port, rpmsg_tty_driver, cport->id, dev); if (IS_ERR(tty_dev)) { - dev_err(dev, "Failed to register tty port\n"); - ret = PTR_ERR(tty_dev); - goto err_destroy; + ret = dev_err_probe(dev, PTR_ERR(tty_dev), "Failed to register tty port\n"); + goto err_destroy; } cport->rpdev = rpdev;