From: Dan Carpenter Date: Wed, 7 Jan 2015 11:01:26 +0000 (+0300) Subject: drm/tegra: dc: Fix bad irqsave/restore in tegra_dc_finish_page_flip() X-Git-Tag: v4.0-rc1~74^2~25^2~37 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8643bc6d8e3701734a86d2ae2da32bbfaf1d4535;p=platform%2Fkernel%2Flinux-exynos.git drm/tegra: dc: Fix bad irqsave/restore in tegra_dc_finish_page_flip() We can't save two values to the IRQ flags at the same time so the IRQs are not enabled at the end. This kind of bug is easy to miss in testing if the function is normally called with IRQs disabled so we wouldn't enable IRQs anyway. Signed-off-by: Dan Carpenter Signed-off-by: Thierry Reding --- diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c index c2ab1a2..aca886e 100644 --- a/drivers/gpu/drm/tegra/dc.c +++ b/drivers/gpu/drm/tegra/dc.c @@ -867,7 +867,7 @@ static void tegra_dc_finish_page_flip(struct tegra_dc *dc) bo = tegra_fb_get_plane(crtc->primary->fb, 0); - spin_lock_irqsave(&dc->lock, flags); + spin_lock(&dc->lock); /* check if new start address has been latched */ tegra_dc_writel(dc, WINDOW_A_SELECT, DC_CMD_DISPLAY_WINDOW_HEADER); @@ -875,7 +875,7 @@ static void tegra_dc_finish_page_flip(struct tegra_dc *dc) base = tegra_dc_readl(dc, DC_WINBUF_START_ADDR); tegra_dc_writel(dc, 0, DC_CMD_STATE_ACCESS); - spin_unlock_irqrestore(&dc->lock, flags); + spin_unlock(&dc->lock); if (base == bo->paddr + crtc->primary->fb->offsets[0]) { drm_crtc_send_vblank_event(crtc, dc->event);