From: Peter Oberparleiter Date: Tue, 27 Oct 2015 09:49:54 +0000 (+0100) Subject: scsi_sysfs: Fix queue_ramp_up_period return code X-Git-Tag: v4.14-rc1~4218^2^2~90 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=863e02d0e173bb9d8cea6861be22820b25c076cc;p=platform%2Fkernel%2Flinux-rpi.git scsi_sysfs: Fix queue_ramp_up_period return code Writing a number to /sys/bus/scsi/devices//queue_ramp_up_period returns the value of that number instead of the number of bytes written. This behavior can confuse programs expecting POSIX write() semantics. Fix this by returning the number of bytes written instead. Signed-off-by: Peter Oberparleiter Reviewed-by: Hannes Reinecke Cc: stable@vger.kernel.org Reviewed-by: Matthew R. Ochs Reviewed-by: Ewan D. Milne Signed-off-by: Martin K. Petersen --- diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c index fdcf0ab..8b7fa8a 100644 --- a/drivers/scsi/scsi_sysfs.c +++ b/drivers/scsi/scsi_sysfs.c @@ -921,7 +921,7 @@ sdev_store_queue_ramp_up_period(struct device *dev, return -EINVAL; sdev->queue_ramp_up_period = msecs_to_jiffies(period); - return period; + return count; } static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,