From: Jérôme Pouiller Date: Tue, 17 Dec 2019 16:14:37 +0000 (+0000) Subject: staging: wfx: detect race condition in WEP authentication X-Git-Tag: v5.10.7~3370^2~183 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8608ecdba5ce98031237add7727f8b9df457e381;p=platform%2Fkernel%2Flinux-rpi.git staging: wfx: detect race condition in WEP authentication Current code has a special case to handle association with WEP. Before to rework the tx data handling, let's try to detect any possible misuse of this code. Signed-off-by: Jérôme Pouiller Link: https://lore.kernel.org/r/20191217161318.31402-9-Jerome.Pouiller@silabs.com Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/wfx/queue.c b/drivers/staging/wfx/queue.c index c7ee908..680fed3 100644 --- a/drivers/staging/wfx/queue.c +++ b/drivers/staging/wfx/queue.c @@ -422,6 +422,7 @@ static bool hif_handle_tx_data(struct wfx_vif *wvif, struct sk_buff *skb, break; case do_wep: wfx_tx_lock(wvif->wdev); + WARN_ON(wvif->wep_pending_skb); wvif->wep_default_key_id = tx_priv->hw_key->keyidx; wvif->wep_pending_skb = skb; if (!schedule_work(&wvif->wep_key_work))