From: Kitae Kim <kt920.kim@samsung.com>
Date: Thu, 7 Aug 2014 05:02:00 +0000 (+0900)
Subject: tethering: remove redundant source when copying ip address.
X-Git-Tag: Tizen_Studio_1.3_Release_p2.3.1~263^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8602e7b268d1da735c2927a53f935cb5d9d3de3f;p=sdk%2Femulator%2Fqemu.git

tethering: remove redundant source when copying ip address.

Change-Id: I895fef95e6a7d1f993220f07cea06bdbb00d7b90
Signed-off-by: Kitae Kim <kt920.kim@samsung.com>
---

diff --git a/tizen/src/ecs/ecs_tethering.c b/tizen/src/ecs/ecs_tethering.c
index 9825e1c4ae..b4d488361a 100644
--- a/tizen/src/ecs/ecs_tethering.c
+++ b/tizen/src/ecs/ecs_tethering.c
@@ -238,7 +238,6 @@ bool msgproc_tethering_req(ECS_Client* ccli, ECS__TetheringReq* msg)
             // get ip address and port
             if (msg->data.data && msg->data.len > 0) {
                 const gchar *data = (const gchar *)msg->data.data;
-                // gchar **server_addr = NULL;
                 gchar *ip_address = NULL;
                 guint64 port = 0;
 
diff --git a/tizen/src/tethering/common.c b/tizen/src/tethering/common.c
index 3a23a0188a..9796a079c8 100644
--- a/tizen/src/tethering/common.c
+++ b/tizen/src/tethering/common.c
@@ -61,6 +61,7 @@ MULTI_DEBUG_CHANNEL(tizen, app_tethering);
 #endif
 
 #define SEND_BUF_MAX_SIZE 4096
+static const char *loopback = "127.0.0.1";
 
 typedef struct tethering_recv_buf {
     uint32_t len;
@@ -607,21 +608,14 @@ static int start_tethering_socket(const char *ipaddress, int port)
 {
     struct sockaddr_in addr;
 
-    gchar serveraddr[32] = { 0, };
     int sock = -1;
     int ret = 0;
 
     addr.sin_family = AF_INET;
     addr.sin_port = htons(port); // i.e. 1234
 
-    if (ipaddress == NULL) {
-        g_strlcpy(serveraddr, "127.0.0.1", sizeof(serveraddr));
-    } else {
-        g_strlcpy(serveraddr, ipaddress, sizeof(serveraddr));
-    }
-
-    INFO("server ip address: %s, port: %d\n", serveraddr, port);
-    ret = inet_aton(serveraddr, &addr.sin_addr);
+    INFO("server ip address: %s, port: %d\n", ipaddress, port);
+    ret = inet_aton(ipaddress, &addr.sin_addr);
 
     if (ret == 0) {
         ERR("inet_aton failure\n");
@@ -773,6 +767,7 @@ static void *initialize_tethering_socket(void *opaque);
 int connect_tethering_app(const char *ipaddress, int port)
 {
     TetheringState *client = NULL;
+    int ipaddr_len = 0;
 
     client = g_malloc0(sizeof(TetheringState));
     if (!client) {
@@ -782,20 +777,18 @@ int connect_tethering_app(const char *ipaddress, int port)
     client->port = port;
 
     if (ipaddress) {
-        int ipaddr_len = 0;
-
         ipaddr_len = strlen(ipaddress);
-
-        client->ipaddress = g_malloc0(ipaddr_len + 1);
-        if (!client->ipaddress) {
-            g_free(client);
-            return -1;
-        }
-
-        g_strlcpy(client->ipaddress, ipaddress, ipaddr_len);
     } else {
-        client->ipaddress = NULL;
+        ipaddr_len = strlen(loopback);
+        ipaddress = loopback;
+    }
+
+    client->ipaddress = g_malloc0(ipaddr_len + 1);
+    if (!client->ipaddress) {
+        g_free(client);
+        return -1;
     }
+    g_strlcpy(client->ipaddress, ipaddress, ipaddr_len + 1);
 
     tethering_client = client;