From: Lee Jones Date: Fri, 17 Jul 2020 13:54:24 +0000 (+0100) Subject: spi: spi-amd: Do not define 'struct acpi_device_id' when !CONFIG_ACPI X-Git-Tag: v5.15~2780^2~43 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=85ed0f63c0e362afc51e541a8216a58094c36f6b;p=platform%2Fkernel%2Flinux-starfive.git spi: spi-amd: Do not define 'struct acpi_device_id' when !CONFIG_ACPI Since ACPI_PTR() is used to NULLify the value when !CONFIG_ACPI, struct 'spi_acpi_match' becomes defined but unused. Fixes the following W=1 kernel build warning(s): drivers/spi/spi-amd.c:297:36: warning: ‘spi_acpi_match’ defined but not used [-Wunused-const-variable=] 297 | static const struct acpi_device_id spi_acpi_match[] = { | ^~~~~~~~~~~~~~ Signed-off-by: Lee Jones Cc: Sanjay R Mehta Link: https://lore.kernel.org/r/20200717135424.2442271-15-lee.jones@linaro.org Signed-off-by: Mark Brown --- diff --git a/drivers/spi/spi-amd.c b/drivers/spi/spi-amd.c index d0aacd4..7f62954 100644 --- a/drivers/spi/spi-amd.c +++ b/drivers/spi/spi-amd.c @@ -294,11 +294,13 @@ err_free_master: return err; } +#ifdef CONFIG_ACPI static const struct acpi_device_id spi_acpi_match[] = { { "AMDI0061", 0 }, {}, }; MODULE_DEVICE_TABLE(acpi, spi_acpi_match); +#endif static struct platform_driver amd_spi_driver = { .driver = {