From: Vladimir Prus <vladimir@codesourcery.com>
Date: Wed, 24 Jan 2007 19:54:13 +0000 (+0000)
Subject:         * varobj.c (c_value_of_root, c_value_of_child)
X-Git-Tag: drow-reverse-20070409-branchpoint~707
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=85d93f1df0c6a196327ecde7fdb4e72dbc879ee7;p=external%2Fbinutils.git

    * varobj.c (c_value_of_root, c_value_of_child)
        (cplus_describe_child): Don't call release_value.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index e195ca8..bcb1a1d 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2007-01-24  Vladimir Prus  <vladimir@codesourcery.com>
+
+	* varobj.c (c_value_of_root, c_value_of_child)
+	(cplus_describe_child): Don't call release_value.
+
 2007-01-24  Thiemo Seufer  <ths@mips.com>
 
 	* mips-linux-tdep.c (mips_linux_n64_rt_sigframe): Fix struct
diff --git a/gdb/varobj.c b/gdb/varobj.c
index ccca051..578a4d1 100644
--- a/gdb/varobj.c
+++ b/gdb/varobj.c
@@ -2020,13 +2020,8 @@ c_value_of_root (struct varobj **var_handle)
   if (within_scope)
     {
       /* We need to catch errors here, because if evaluate
-         expression fails we just want to make val->error = 1 and
-         go on */
-      if (gdb_evaluate_expression (var->root->exp, &new_val))
-	{
-	  release_value (new_val);
-	}
-
+         expression fails we want to just return NULL.  */
+      gdb_evaluate_expression (var->root->exp, &new_val);
       return new_val;
     }
 
@@ -2038,8 +2033,6 @@ c_value_of_child (struct varobj *parent, int index)
 {
   struct value *value = NULL;
   c_describe_child (parent, index, NULL, &value, NULL);
-  if (value != NULL)
-    release_value (value);
 
   return value;
 }
@@ -2304,7 +2297,6 @@ cplus_describe_child (struct varobj *parent, int index,
 	  if (cvalue && value)
 	    {
 	      *cvalue = value_cast (TYPE_FIELD_TYPE (type, index), value);
-	      release_value (*cvalue);
 	    }
 
 	  if (ctype)