From: George Karpenkov <ekarpenkov@apple.com>
Date: Fri, 3 Nov 2017 00:41:29 +0000 (+0000)
Subject: [analyzer] [NFC] very minor ExprEngineC refactoring
X-Git-Tag: llvmorg-6.0.0-rc1~4249
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=85a34aa21e5aea550c67005768c99abb14f90095;p=platform%2Fupstream%2Fllvm.git

[analyzer] [NFC] very minor ExprEngineC refactoring

Differential Revision: https://reviews.llvm.org/D39577

llvm-svn: 317294
---

diff --git a/clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp b/clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp
index 6f1e839..6c69542 100644
--- a/clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp
+++ b/clang/lib/StaticAnalyzer/Core/ExprEngineC.cpp
@@ -92,12 +92,10 @@ void ExprEngine::VisitBinaryOperator(const BinaryOperator* B,
       // Process non-assignments except commas or short-circuited
       // logical expressions (LAnd and LOr).
       SVal Result = evalBinOp(state, Op, LeftV, RightV, B->getType());
-      if (Result.isUnknown()) {
-        Bldr.generateNode(B, *it, state);
-        continue;
+      if (!Result.isUnknown()) {
+        state = state->BindExpr(B, LCtx, Result);
       }
 
-      state = state->BindExpr(B, LCtx, Result);
       Bldr.generateNode(B, *it, state);
       continue;
     }