From: Father Chrysostomos Date: Fri, 8 Apr 2011 16:08:02 +0000 (-0700) Subject: Revert "[perl #87708] $tied / $tied under use integer" X-Git-Tag: accepted/trunk/20130322.191538~4462 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=85935d8e7bc504b57c9aea69973920ebe632631d;p=platform%2Fupstream%2Fperl.git Revert "[perl #87708] $tied / $tied under use integer" This reverts most of commit 76422f81b675011beffbdb66c981a36b6fbf4a6b. It is now unnecessary as of commit 75ea7a1. --- diff --git a/pp.c b/pp.c index 941cc9d..9858f91 100644 --- a/pp.c +++ b/pp.c @@ -2846,14 +2846,15 @@ PP(pp_i_multiply) PP(pp_i_divide) { + IV num; dVAR; dSP; dATARGET; tryAMAGICbin_MG(div_amg, AMGf_assign); { dPOPTOPssrl; - IV num = SvIV_nomg(left); - IV value = left==right ? SvIV(right) : SvIV_nomg(right); + IV value = SvIV_nomg(right); if (value == 0) DIE(aTHX_ "Illegal division by zero"); + num = SvIV_nomg(left); /* avoid FPE_INTOVF on some platforms when num is IV_MIN */ if (value == -1) diff --git a/t/lib/warnings/9uninit b/t/lib/warnings/9uninit index 4472db4..b73edf4 100644 --- a/t/lib/warnings/9uninit +++ b/t/lib/warnings/9uninit @@ -562,7 +562,6 @@ Use of uninitialized value $m1 in integer subtraction (-) at - line 7. Use of uninitialized value $g1 in integer subtraction (-) at - line 7. Use of uninitialized value $m1 in integer multiplication (*) at - line 8. Use of uninitialized value $g1 in integer multiplication (*) at - line 8. -Use of uninitialized value $m1 in integer division (/) at - line 9. Use of uninitialized value $g1 in integer division (/) at - line 9. Use of uninitialized value $m2 in integer division (/) at - line 10. Use of uninitialized value $m1 in integer modulus (%) at - line 11.