From: Luca Ellero Date: Thu, 10 Jul 2014 09:01:58 +0000 (+0200) Subject: staging: ced1401: fix ced_read_char() X-Git-Tag: v4.14-rc1~7109^2~1013 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=858166f9f27a3a2d53eb50ef0429d13be8499875;p=platform%2Fkernel%2Flinux-rpi.git staging: ced1401: fix ced_read_char() Rename camel case arguments and locals in function ced_read_char() Signed-off-by: Luca Ellero Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/ced1401/usb1401.c b/drivers/staging/ced1401/usb1401.c index 8007085..17d1c60 100644 --- a/drivers/staging/ced1401/usb1401.c +++ b/drivers/staging/ced1401/usb1401.c @@ -937,20 +937,21 @@ int ced_read_write_mem(struct ced_data *ced, bool read, unsigned short ident, ** data we return FALSE. Used as part of decoding a DMA request. ** ****************************************************************************/ -static bool ced_read_char(unsigned char *pChar, char *pBuf, unsigned int *pdDone, - unsigned int dGot) +static bool ced_read_char(unsigned char *character, char *buf, + unsigned int *n_done, unsigned int got) { - bool bRead = false; - unsigned int dDone = *pdDone; - - if (dDone < dGot) { /* If there is more data */ - *pChar = (unsigned char)pBuf[dDone]; /* Extract the next char */ - dDone++; /* Increment the done count */ - *pdDone = dDone; - bRead = true; /* and flag success */ + bool read = false; + unsigned int done = *n_done; + + if (done < got) { /* If there is more data */ + /* Extract the next char */ + *character = (unsigned char)buf[done]; + done++; /* Increment the done count */ + *n_done = done; + read = true; /* and flag success */ } - return bRead; + return read; } #ifdef NOTUSED