From: Stefan Weil <sw@weilnetz.de>
Date: Wed, 11 Mar 2015 21:08:56 +0000 (+0100)
Subject: trace/simple: Fix warning and wrong trace file name for MinGW
X-Git-Tag: Tizen_Studio_1.3_Release_p2.3.2~121^2~1^2~28^2~2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=857a0e387a6c91b5ea012aafae04c95eba314306;p=sdk%2Femulator%2Fqemu.git

trace/simple: Fix warning and wrong trace file name for MinGW

On Windows, getpid() always returns an int value, but pid_t (which is
expected by the format string) is either a 32 bit or a 64 bit value.

Without a type cast (or a modified format string), the compiler prints
a warning when building for 64 bit Windows and the resulting trace_file_name
will include a wrong pid:

trace/simple.c:332:9: warning:
 format ‘%lld’ expects argument of type ‘long long int’,
 but argument 2 has type ‘int’ [-Wformat=]

Signed-off-by: Stefan Weil <sw@weilnetz.de>
---

diff --git a/trace/simple.c b/trace/simple.c
index 11ad030937..56a624cac8 100644
--- a/trace/simple.c
+++ b/trace/simple.c
@@ -329,7 +329,8 @@ bool st_set_trace_file(const char *file)
     g_free(trace_file_name);
 
     if (!file) {
-        trace_file_name = g_strdup_printf(CONFIG_TRACE_FILE, getpid());
+        /* Type cast needed for Windows where getpid() returns an int. */
+        trace_file_name = g_strdup_printf(CONFIG_TRACE_FILE, (pid_t)getpid());
     } else {
         trace_file_name = g_strdup_printf("%s", file);
     }