From: Dario Binacchi <dariobin@libero.it>
Date: Wed, 27 May 2020 11:56:21 +0000 (+0200)
Subject: spl: fit: improve spl_nand_fit_read(...) readability
X-Git-Tag: v2020.10~127^2~7
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=84dd1902443cf500b2536eeb14d6662c6b502698;p=platform%2Fkernel%2Fu-boot.git

spl: fit: improve spl_nand_fit_read(...) readability

Replacing the ret variable with err and handling first the error
condition about the value returned by the spl_nand_fit_read routine,
improves the code readability.
Furthermore, the 'else' int the 'else return ret' instruction was
useless.

cc: Michael Trimarchi <michael@amarulasolutions.com>
Signed-off-by: Dario Binacchi <dariobin@libero.it>
---

diff --git a/common/spl/spl_nand.c b/common/spl/spl_nand.c
index 1e6f2dc..d13a524 100644
--- a/common/spl/spl_nand.c
+++ b/common/spl/spl_nand.c
@@ -43,15 +43,15 @@ static ulong spl_nand_fit_read(struct spl_load_info *load, ulong offs,
 			       ulong size, void *dst)
 {
 	ulong sector;
-	int ret;
+	int err;
 
 	sector = *(int *)load->priv;
 	offs = sector + nand_spl_adjust_offset(sector, offs - sector);
-	ret = nand_spl_load_image(offs, size, dst);
-	if (!ret)
-		return size;
-	else
+	err = nand_spl_load_image(offs, size, dst);
+	if (err)
 		return 0;
+
+	return size;
 }
 
 static int spl_nand_load_element(struct spl_image_info *spl_image,