From: Nick Hu Date: Tue, 17 Jan 2023 08:14:28 +0000 (+0800) Subject: lib: sbi_hsm: Use csr_set to restore the MIP X-Git-Tag: v1.3~121 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=84d15f4f529c92d3f32fbc570c02f7d40e9e70cb;p=platform%2Fkernel%2Fopensbi.git lib: sbi_hsm: Use csr_set to restore the MIP If we use the csr_write to restore the MIP, we may clear the SEIP. In generic behavior of QEMU, if the pending bits of PLIC are set and we clear the SEIP, the QEMU may not set it back immediately. It may cause the interrupts won't be handled anymore until the new interrupts arrived and QEMU set the bits back. Signed-off-by: Nick Hu Signed-off-by: Jim Shu Reviewed-by: Anup Patel --- diff --git a/lib/sbi/sbi_hsm.c b/lib/sbi/sbi_hsm.c index d4cce4a..8499bb1 100644 --- a/lib/sbi/sbi_hsm.c +++ b/lib/sbi/sbi_hsm.c @@ -357,7 +357,7 @@ static void __sbi_hsm_suspend_non_ret_restore(struct sbi_scratch *scratch) hart_data_offset); csr_write(CSR_MIE, hdata->saved_mie); - csr_write(CSR_MIP, (hdata->saved_mip & (MIP_SSIP | MIP_STIP))); + csr_set(CSR_MIP, (hdata->saved_mip & (MIP_SSIP | MIP_STIP))); } void sbi_hsm_hart_resume_start(struct sbi_scratch *scratch)