From: Carol Eidt Date: Tue, 3 Jul 2018 16:46:04 +0000 (-0700) Subject: Remove Interval::isMultiReg X-Git-Tag: submit/tizen/20210909.063632~11030^2~4448^2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=84ca1d65aa0ba0e7029d89c1b7ce900d6e7a0825;p=platform%2Fupstream%2Fdotnet%2Fruntime.git Remove Interval::isMultiReg This is no longer used after dotnet/coreclr#16517 Commit migrated from https://github.com/dotnet/coreclr/commit/5d01d2d16f4a4c9592002d7c76c19f01f2529140 --- diff --git a/src/coreclr/src/jit/lsra.cpp b/src/coreclr/src/jit/lsra.cpp index 01192b2..654b340 100644 --- a/src/coreclr/src/jit/lsra.cpp +++ b/src/coreclr/src/jit/lsra.cpp @@ -2684,8 +2684,7 @@ regNumber LinearScan::tryAllocateFreeReg(Interval* currentInterval, RefPosition* { // Don't use the relatedInterval for preferencing if its next reference is not a new definition, // or if it is only related because they are multi-reg targets of the same node. - if (!RefTypeIsDef(nextRelatedRefPosition->refType) || - isMultiRegRelated(nextRelatedRefPosition, refPosition->nodeLocation)) + if (!RefTypeIsDef(nextRelatedRefPosition->refType)) { relatedInterval = nullptr; } @@ -4919,18 +4918,6 @@ bool LinearScan::registerIsFree(regNumber regNum, RegisterType regType) return isFree; } -// isMultiRegRelated: is this RefPosition defining part of a multi-reg value -// at the given location? -// -bool LinearScan::isMultiRegRelated(RefPosition* refPosition, LsraLocation location) -{ -#ifdef FEATURE_MULTIREG_ARGS_OR_RET - return ((refPosition->nodeLocation == location) && refPosition->getInterval()->isMultiReg); -#else - return false; -#endif -} - //------------------------------------------------------------------------ // LinearScan::freeRegister: Make a register available for use // @@ -8596,10 +8583,6 @@ void Interval::dump() { printf(" (constant)"); } - if (isMultiReg) - { - printf(" (multireg)"); - } printf(" RefPositions {"); for (RefPosition* refPosition = this->firstRefPosition; refPosition != nullptr; diff --git a/src/coreclr/src/jit/lsra.h b/src/coreclr/src/jit/lsra.h index e646294..f88f2d9 100644 --- a/src/coreclr/src/jit/lsra.h +++ b/src/coreclr/src/jit/lsra.h @@ -1056,7 +1056,6 @@ private: regMaskTP allSIMDRegs(); regMaskTP internalFloatRegCandidates(); - bool isMultiRegRelated(RefPosition* refPosition, LsraLocation location); bool registerIsFree(regNumber regNum, RegisterType regType); bool registerIsAvailable(RegRecord* physRegRecord, LsraLocation currentLoc, @@ -1655,7 +1654,6 @@ public: , isSpecialPutArg(false) , preferCalleeSave(false) , isConstant(false) - , isMultiReg(false) , physReg(REG_COUNT) #ifdef DEBUG , intervalIndex(0) @@ -1726,9 +1724,6 @@ public: // able to reuse a constant that's already in a register. bool isConstant : 1; - // True if this Interval is defined by a node that produces multiple registers. - bool isMultiReg : 1; - // The register to which it is currently assigned. regNumber physReg;