From: Johannes Berg <johannes.berg@intel.com>
Date: Thu, 13 Dec 2012 22:08:52 +0000 (+0100)
Subject: mac80211: use del_timer_sync for final sta cleanup timer deletion
X-Git-Tag: v3.4.26~84
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=848842e67d24fed13a2aece3d03e235267e5a3a6;p=platform%2Fkernel%2Flinux-stable.git

mac80211: use del_timer_sync for final sta cleanup timer deletion

commit a56f992cdabc63f56b4b142885deebebf936ff76 upstream.

This is a very old bug, but there's nothing that prevents the
timer from running while the module is being removed when we
only do del_timer() instead of del_timer_sync().

The timer should normally not be running at this point, but
it's not clearly impossible (or we could just remove this.)

Tested-by: Ben Greear <greearb@candelatech.com>
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/net/mac80211/sta_info.c b/net/mac80211/sta_info.c
index 6d25d77..e2e0e0b 100644
--- a/net/mac80211/sta_info.c
+++ b/net/mac80211/sta_info.c
@@ -844,7 +844,7 @@ void sta_info_init(struct ieee80211_local *local)
 
 void sta_info_stop(struct ieee80211_local *local)
 {
-	del_timer(&local->sta_cleanup);
+	del_timer_sync(&local->sta_cleanup);
 	sta_info_flush(local, NULL);
 }