From: Armin Novak <armin.novak@thincast.com>
Date: Thu, 25 Oct 2018 10:49:42 +0000 (+0200)
Subject: Fixed resource leak in rpc_ntlm_http_request
X-Git-Tag: 2.0.0-rc4~29^2~4
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=847ee233f424bc3466c6183667be9f17f4270e2f;p=platform%2Fupstream%2Ffreerdp.git

Fixed resource leak in rpc_ntlm_http_request
---

diff --git a/libfreerdp/core/gateway/ncacn_http.c b/libfreerdp/core/gateway/ncacn_http.c
index a1c8916..10813a8 100644
--- a/libfreerdp/core/gateway/ncacn_http.c
+++ b/libfreerdp/core/gateway/ncacn_http.c
@@ -44,6 +44,9 @@ static wStream* rpc_ntlm_http_request(HttpContext* http, const char* method,
 
 	request = http_request_new();
 
+	if (!request)
+		goto fail;
+
 	if (ntlmToken)
 		base64NtlmToken = crypto_base64_encode(ntlmToken->pvBuffer, ntlmToken->cbBuffer);
 
@@ -52,7 +55,7 @@ static wStream* rpc_ntlm_http_request(HttpContext* http, const char* method,
 	if (!http_request_set_method(request, method) ||
 	    !http_request_set_content_length(request, contentLength) ||
 	    !http_request_set_uri(request, uri))
-		return NULL;
+		goto fail;
 
 	if (base64NtlmToken)
 	{