From: Axel Lin <axel.lin@ingics.com>
Date: Fri, 14 Dec 2012 12:07:00 +0000 (+0000)
Subject: iio: dac: ad5624r_spi: Don't set error code to voltage_uv
X-Git-Tag: upstream/snapshot3+hdmi~5854^2~2^2~5
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8434e7856551015650f62afa48e8f9e9b4bf80f2;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git

iio: dac: ad5624r_spi: Don't set error code to voltage_uv

regulator_get_voltage() may return negative error code.
Add error checking to avoid setting error code to voltage_uv.

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Acked-by: Lars-Peter Clausen <lars@metafoo.de>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>
---

diff --git a/drivers/iio/dac/ad5624r_spi.c b/drivers/iio/dac/ad5624r_spi.c
index 6a7d6a4..14ea3db 100644
--- a/drivers/iio/dac/ad5624r_spi.c
+++ b/drivers/iio/dac/ad5624r_spi.c
@@ -238,7 +238,11 @@ static int __devinit ad5624r_probe(struct spi_device *spi)
 		if (ret)
 			goto error_put_reg;
 
-		voltage_uv = regulator_get_voltage(st->reg);
+		ret = regulator_get_voltage(st->reg);
+		if (ret < 0)
+			goto error_disable_reg;
+
+		voltage_uv = ret;
 	}
 
 	spi_set_drvdata(spi, indio_dev);