From: Jeremy Cline Date: Mon, 11 Jan 2021 16:40:33 +0000 (-0500) Subject: drm/ttm: Fix address passed to dma_mapping_error() in ttm_pool_map() X-Git-Tag: accepted/tizen/unified/20230118.172025~8084^2~3^2~2 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=843010a815e87b45fc6b64848f02e42f6aee3f22;p=platform%2Fkernel%2Flinux-rpi.git drm/ttm: Fix address passed to dma_mapping_error() in ttm_pool_map() check_unmap() is producing a warning about a missing map error check. The return value from dma_map_page() should be checked for an error, not the caller-provided dma_addr. Fixes: d099fc8f540a ("drm/ttm: new TT backend allocation pool v3") Signed-off-by: Jeremy Cline Reviewed-by: Christian König Link: https://patchwork.freedesktop.org/patch/413432/ Signed-off-by: Christian König --- diff --git a/drivers/gpu/drm/ttm/ttm_pool.c b/drivers/gpu/drm/ttm/ttm_pool.c index a00b7ab..255c457 100644 --- a/drivers/gpu/drm/ttm/ttm_pool.c +++ b/drivers/gpu/drm/ttm/ttm_pool.c @@ -190,7 +190,7 @@ static int ttm_pool_map(struct ttm_pool *pool, unsigned int order, size_t size = (1ULL << order) * PAGE_SIZE; addr = dma_map_page(pool->dev, p, 0, size, DMA_BIDIRECTIONAL); - if (dma_mapping_error(pool->dev, **dma_addr)) + if (dma_mapping_error(pool->dev, addr)) return -EFAULT; }