From: Yangtao Li Date: Tue, 20 Jun 2023 09:07:22 +0000 (+0800) Subject: thermal/hwmon: Add error information printing for devm_thermal_add_hwmon_sysfs() X-Git-Tag: v6.6.7~2584^2^2~11 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8416ecfb3292321c55719c7c1a69dec7769bfbc1;p=platform%2Fkernel%2Flinux-starfive.git thermal/hwmon: Add error information printing for devm_thermal_add_hwmon_sysfs() Ensure that all error handling branches print error information. In this way, when this function fails, the upper-layer functions can directly return an error code without missing debugging information. Otherwise, the error message will be printed redundantly or missing. Signed-off-by: Yangtao Li Signed-off-by: Daniel Lezcano Link: https://lore.kernel.org/r/20230620090732.50025-1-frank.li@vivo.com --- diff --git a/drivers/thermal/thermal_hwmon.c b/drivers/thermal/thermal_hwmon.c index fbe55509e307..c3ae44659b81 100644 --- a/drivers/thermal/thermal_hwmon.c +++ b/drivers/thermal/thermal_hwmon.c @@ -271,11 +271,14 @@ int devm_thermal_add_hwmon_sysfs(struct device *dev, struct thermal_zone_device ptr = devres_alloc(devm_thermal_hwmon_release, sizeof(*ptr), GFP_KERNEL); - if (!ptr) + if (!ptr) { + dev_warn(dev, "Failed to allocate device resource data\n"); return -ENOMEM; + } ret = thermal_add_hwmon_sysfs(tz); if (ret) { + dev_warn(dev, "Failed to add hwmon sysfs attributes\n"); devres_free(ptr); return ret; }