From: Sebastian Andrzej Siewior Date: Fri, 11 Feb 2022 18:14:58 +0000 (+0100) Subject: mfd: ezx-pcap: Use generic_handle_irq_safe(). X-Git-Tag: v6.1-rc5~1819^2~4 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=83d9b7e3955d32d3e4e3321029f655716cb21c99;p=platform%2Fkernel%2Flinux-starfive.git mfd: ezx-pcap: Use generic_handle_irq_safe(). Instead of manually disabling interrupts before invoking use generic_handle_irq_safe() which can be invoked with enabled and disabled interrupts. Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Thomas Gleixner Cc: Lee Jones Link: https://lore.kernel.org/r/20220211181500.1856198-6-bigeasy@linutronix.de --- diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c index 70fa18b..b14d3f9 100644 --- a/drivers/mfd/ezx-pcap.c +++ b/drivers/mfd/ezx-pcap.c @@ -193,13 +193,11 @@ static void pcap_isr_work(struct work_struct *work) ezx_pcap_write(pcap, PCAP_REG_MSR, isr | msr); ezx_pcap_write(pcap, PCAP_REG_ISR, isr); - local_irq_disable(); service = isr & ~msr; for (irq = pcap->irq_base; service; service >>= 1, irq++) { if (service & 1) - generic_handle_irq(irq); + generic_handle_irq_safe(irq); } - local_irq_enable(); ezx_pcap_write(pcap, PCAP_REG_MSR, pcap->msr); } while (gpio_get_value(pdata->gpio)); }