From: Christoph Hellwig Date: Sat, 20 May 2017 16:59:54 +0000 (+0200) Subject: PCI/msi: fix the pci_alloc_irq_vectors_affinity stub X-Git-Tag: v4.14-rc1~849 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=83b4605b0c16cde5b00c8cf192408d51eab75402;p=platform%2Fkernel%2Flinux-rpi3.git PCI/msi: fix the pci_alloc_irq_vectors_affinity stub We need to return an error for any call that asks for MSI / MSI-X vectors only, so that non-trivial fallback logic can work properly. Also valid dev->irq and use the "correct" errno value based on feedback from Linus. Signed-off-by: Christoph Hellwig Reported-by: Steven Rostedt Fixes: aff17164 ("PCI: Provide sensible IRQ vector alloc/free routines") Signed-off-by: Linus Torvalds --- diff --git a/include/linux/pci.h b/include/linux/pci.h index 33c2b0b..fc2e832 100644 --- a/include/linux/pci.h +++ b/include/linux/pci.h @@ -1342,9 +1342,9 @@ pci_alloc_irq_vectors_affinity(struct pci_dev *dev, unsigned int min_vecs, unsigned int max_vecs, unsigned int flags, const struct irq_affinity *aff_desc) { - if (min_vecs > 1) - return -EINVAL; - return 1; + if ((flags & PCI_IRQ_LEGACY) && min_vecs == 1 && dev->irq) + return 1; + return -ENOSPC; } static inline void pci_free_irq_vectors(struct pci_dev *dev)