From: jarin@chromium.org Date: Mon, 3 Nov 2014 13:58:39 +0000 (+0000) Subject: [turbofan] Fix Typer::Rangify to handle integral bitset types. X-Git-Tag: upstream/4.7.83~5941 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=83806d568ddf4b9fe5f4e0a45ecf8c9bb7635cef;p=platform%2Fupstream%2Fv8.git [turbofan] Fix Typer::Rangify to handle integral bitset types. R=bmeurer@chromium.org BUG= Review URL: https://codereview.chromium.org/688413003 Cr-Commit-Position: refs/heads/master@{#25074} git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@25074 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- diff --git a/src/compiler/typer.cc b/src/compiler/typer.cc index 3649f7d..d7faa5a 100644 --- a/src/compiler/typer.cc +++ b/src/compiler/typer.cc @@ -408,10 +408,19 @@ Type* Typer::Visitor::FalsifyUndefined(Type* type, Typer* t) { Type* Typer::Visitor::Rangify(Type* type, Typer* t) { if (type->IsRange()) return type; // Shortcut. - if (!type->Is(t->integer)) return type; // Give up. + if (!type->Is(t->integer) && !type->Is(Type::Integral32())) { + return type; // Give up on non-integer types. + } + double min = type->Min(); + double max = type->Max(); + // Handle the degenerate case of empty bitset types (such as + // OtherUnsigned31 and OtherSigned32 on 64-bit architectures). + if (std::isnan(min)) { + DCHECK(std::isnan(max)); + return type; + } Factory* f = t->isolate()->factory(); - return Type::Range(f->NewNumber(type->Min()), f->NewNumber(type->Max()), - t->zone()); + return Type::Range(f->NewNumber(min), f->NewNumber(max), t->zone()); }