From: G. Campana Date: Thu, 19 Jan 2017 21:37:46 +0000 (+0200) Subject: virtio_console: fix a crash in config_work_handler X-Git-Tag: v4.14-rc1~1655^2~5 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8379cadf71c3ee8173a1c6fc1ea7762a9638c047;p=platform%2Fkernel%2Flinux-rpi3.git virtio_console: fix a crash in config_work_handler Using control_work instead of config_work as the 3rd argument to container_of results in an invalid portdev pointer. Indeed, the work structure is initialized as below: INIT_WORK(&portdev->config_work, &config_work_handler); It leads to a crash when portdev->vdev is dereferenced later. This bug is triggered when the guest uses a virtio-console without multiport feature and receives a config_changed virtio interrupt. Signed-off-by: G. Campana Reviewed-by: Amit Shah Signed-off-by: Michael S. Tsirkin --- diff --git a/drivers/char/virtio_console.c b/drivers/char/virtio_console.c index 8b00e79..17857be 100644 --- a/drivers/char/virtio_console.c +++ b/drivers/char/virtio_console.c @@ -1862,7 +1862,7 @@ static void config_work_handler(struct work_struct *work) { struct ports_device *portdev; - portdev = container_of(work, struct ports_device, control_work); + portdev = container_of(work, struct ports_device, config_work); if (!use_multiport(portdev)) { struct virtio_device *vdev; struct port *port;