From: Tomasz Marciniak <t.marciniak@samsung.com>
Date: Wed, 4 Nov 2015 11:18:50 +0000 (+0100)
Subject: Revert "[systemsetting] - Checking privileges moved to JS layer"
X-Git-Tag: submit/tizen_mobile/20151215.080542^2~25^2
X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8371f95b6d28a6885cb8cf3391ba5c01791bf832;p=platform%2Fcore%2Fapi%2Fwebapi-plugins.git

Revert "[systemsetting] - Checking privileges moved to JS layer"

This reverts commit 2bbad674b5c99a6d4ccafc39d0f98b47a80c9c29.
This also applies changes from commit 8f7f932bde2e3b5bd4697d40a5ee61d10509abb9

[Verification] Code compiles. TCT pass didn't change against results on: http://168.219.209.56/confluence/display/WRT/TCT+results+-+WebAPI+for+Tizen+3.0+Mobile

Change-Id: I00cda286d339e4a1740e7fbcbac2474eb97a0480
Signed-off-by: Tomasz Marciniak <t.marciniak@samsung.com>
---

diff --git a/src/systemsetting/systemsetting_api.js b/src/systemsetting/systemsetting_api.js
index 464a33e2..1f432a93 100644
--- a/src/systemsetting/systemsetting_api.js
+++ b/src/systemsetting/systemsetting_api.js
@@ -16,23 +16,10 @@
 
 
 var validator_ = xwalk.utils.validator;
-var privilege_ = xwalk.utils.privilege;
 var type_ = xwalk.utils.type;
 var types_ = validator_.Types;
 var native_ = new xwalk.utils.NativeManager(extension);
 
-function throwException_(err) {
-    throw new WebAPIException(err.code, err.name, err.message);
-}
-
-function callSync_(msg) {
-    var ret = extension.internal.sendSyncMessage(JSON.stringify(msg));
-    var obj = JSON.parse(ret);
-    if (obj.error)
-        throwException_(obj.error);
-    return obj.result;
-}
-
 var SystemSettingTypeValues = ['HOME_SCREEN', 'LOCK_SCREEN', 'INCOMING_CALL', 'NOTIFICATION_EMAIL'];
 
 function SystemSettingManager() {
@@ -58,12 +45,14 @@ SystemSettingManager.prototype.getProperty = function() {
         type: args.type
     };
 
-    native_.call('SystemSettingManager_getProperty', callArgs, callback);
+    var result = native_.call('SystemSettingManager_getProperty', callArgs, callback);
+
+    if (native_.isFailure(result)) {
+      throw native_.getErrorObject(result);
+    }
 };
 
 SystemSettingManager.prototype.setProperty = function() {
-    xwalk.utils.checkPrivilegeAccess(privilege_.SETTING);
-
     var args = validator_.validateArgs(arguments, [
         { name: 'type', type: types_.ENUM, values: SystemSettingTypeValues },
         { name: 'value', type: types_.STRING },
@@ -85,7 +74,11 @@ SystemSettingManager.prototype.setProperty = function() {
         value: args.value
     };
 
-    native_.call('SystemSettingManager_setProperty', callArgs, callback);
+    var result = native_.call('SystemSettingManager_setProperty', callArgs, callback);
+
+    if (native_.isFailure(result)) {
+      throw native_.getErrorObject(result);
+    }
 };
 
 // Exports
diff --git a/src/systemsetting/systemsetting_instance.cc b/src/systemsetting/systemsetting_instance.cc
index 06728d81..7877e848 100644
--- a/src/systemsetting/systemsetting_instance.cc
+++ b/src/systemsetting/systemsetting_instance.cc
@@ -22,6 +22,7 @@
 #include "common/picojson.h"
 #include "common/task-queue.h"
 #include "common/virtual_fs.h"
+#include "common/tools.h"
 
 #include <system_settings.h>
 
@@ -34,6 +35,8 @@ const std::string SETTING_HOME_SCREEN = "HOME_SCREEN";
 const std::string SETTING_LOCK_SCREEN = "LOCK_SCREEN";
 const std::string SETTING_INCOMING_CALL = "INCOMING_CALL";
 const std::string SETTING_NOTIFICATION_EMAIL = "NOTIFICATION_EMAIL";
+
+const std::string kPrivilegeSetting = "http://tizen.org/privilege/setting";
 }
 
 using namespace common;
@@ -137,6 +140,8 @@ void SystemSettingInstance::setProperty(const picojson::value& args, picojson::o
 {
   LoggerD("Enter");
 
+  CHECK_PRIVILEGE_ACCESS(kPrivilegeSetting, &out);
+
   const double callback_id = args.get("callbackId").get<double>();
 
   const std::string& type = args.get("type").get<std::string>();