From: Andreas Kemnade Date: Mon, 17 Sep 2018 05:20:35 +0000 (+0200) Subject: power: supply: twl4030_charger: fix charging current out-of-bounds X-Git-Tag: v5.15~7759^2~7 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=8314c212f995bc0d06b54ad02ef0ab4089781540;p=platform%2Fkernel%2Flinux-starfive.git power: supply: twl4030_charger: fix charging current out-of-bounds the charging current uses unsigned int variables, if we step back if the current is still low, we would run into negative which means setting the target to a huge value. Better add checks here. Signed-off-by: Andreas Kemnade Signed-off-by: Sebastian Reichel --- diff --git a/drivers/power/supply/twl4030_charger.c b/drivers/power/supply/twl4030_charger.c index bbcaee5..c629c16 100644 --- a/drivers/power/supply/twl4030_charger.c +++ b/drivers/power/supply/twl4030_charger.c @@ -420,7 +420,8 @@ static void twl4030_current_worker(struct work_struct *data) if (v < USB_MIN_VOLT) { /* Back up and stop adjusting. */ - bci->usb_cur -= USB_CUR_STEP; + if (bci->usb_cur >= USB_CUR_STEP) + bci->usb_cur -= USB_CUR_STEP; bci->usb_cur_target = bci->usb_cur; } else if (bci->usb_cur >= bci->usb_cur_target || bci->usb_cur + USB_CUR_STEP > USB_MAX_CURRENT) {