From: Yijing Wang Date: Thu, 8 Aug 2013 13:12:36 +0000 (+0800) Subject: iommu/amd: Clean up unnecessary MSI/MSI-X capability find X-Git-Tag: upstream/snapshot3+hdmi~4323^2^5~1 X-Git-Url: http://review.tizen.org/git/?a=commitdiff_plain;h=82fcfc674ebe2a0d83a6dd1b6ffa5589a94e4d4c;p=platform%2Fadaptation%2Frenesas_rcar%2Frenesas_kernel.git iommu/amd: Clean up unnecessary MSI/MSI-X capability find PCI core will initialize device MSI/MSI-X capability in pci_msi_init_pci_dev(). So device driver should use pci_dev->msi_cap/msix_cap to determine whether the device support MSI/MSI-X instead of using pci_find_capability(pci_dev, PCI_CAP_ID_MSI/MSIX). Access to PCIe device config space again will consume more time. Signed-off-by: Yijing Wang Cc: Joerg Roedel Cc: iommu@lists.linux-foundation.org Cc: linux-kernel@vger.kernel.org Signed-off-by: Joerg Roedel --- diff --git a/drivers/iommu/amd_iommu_init.c b/drivers/iommu/amd_iommu_init.c index 7acbf35..8f798be 100644 --- a/drivers/iommu/amd_iommu_init.c +++ b/drivers/iommu/amd_iommu_init.c @@ -1384,7 +1384,7 @@ static int iommu_init_msi(struct amd_iommu *iommu) if (iommu->int_enabled) goto enable_faults; - if (pci_find_capability(iommu->dev, PCI_CAP_ID_MSI)) + if (iommu->dev->msi_cap) ret = iommu_setup_msi(iommu); else ret = -ENODEV;